The mistake is buying on waist measurement alone and assuming the rise will behave itself. It won't. Two pairs can both say a 28 inch waist and sit four inches apart on your body, because the rise length is where high waisted jeans actually succeed or fail, and nobody puts that number on the label. On me, a rise under eleven and a half inches means the waistband sits closer to my actual waist than my actual ribs, which is not the look anyone's going for. Measure the rise against a pair you already trust before you buy, not after.
What kills a good pair of high waisted jeans is almost always what's worn with them, not the jeans themselves. A cropped top that ends exactly at the waistband seam will show a sliver of stomach you didn't plan for, and a boxy jumper tucked in at that height adds bulk precisely where the jeans are already doing structural work. A well made pair earns that structure through decent weight denim, something with a bit of body to it rather than the thin stretch stuff that goes see through at the knee within a month, proper bar tacking at the stress points, and a zip that doesn't need persuading by week three. Cheap ones give themselves away at the back pockets first, the stitching puckers, the rivets go dull, and the waistband starts to roll over rather than sit flat. If you're between sizes, go up rather than down. A high waistband that's a fraction tight will slice across the softest part of your middle all day, and no amount of good denim fixes that.
Where they genuinely don't work is on a short torso, mine included some days depending on the cut, because a deep rise paired with a short body just pushes the waistband up under the bust instead of sitting at the natural waist, and no belt rescues that. They're also the wrong choice if you've got a long torso and a short leg proportion, since the extra rise eats into leg length you didn't have spare to begin with. Over a season, a good pair softens rather than sags, the colour fades evenly if you wash them inside out on a cool cycle and skip the tumble dryer, and the waistband keeps its structure instead of folding over like a sock. Thrown in a bag for a weekend, they come out creased but not stretched, which is the real test. Mine have survived two years of being worn to death and still sit where they started. What they've never managed is to suit every body shape equally, and nothing in this category will.